Avoid using the newgrp command-line tool in the doc#25301
Open
linghengqian wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
area/engine
|
|
||
| ```console | ||
| $ newgrp docker | ||
| $ sudo -u $USER bash |
Contributor
There was a problem hiding this comment.
Thanks for fixing the newgrp dependency problem. Is sudo -u $USER bash known to refresh group membership like newgrp docker does, uniformly across distributions? Maybe it's worth clarifying this for users following the post-installation steps.
Author
There was a problem hiding this comment.
uniformly across distributions?
Yes.
Maybe it's worth clarifying this for users following the post-installation steps.
What are you talking about? Isn't this exactly what current PRs are doing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
util-linux-extrato usenewgrp dockerroadmap#910 .newgrpcommand-line tool in the doc. I don't think requiring users to install an additional apt package is a good option.Related issues or tickets
util-linux-extrato usenewgrp dockerroadmap#910Reviews